Deprecate old cycleNumber in favor of correct connection setting.

lsst · Aug 4, 2022 · eb0f87d · eb0f87d
1 parent 85af353
commit eb0f87d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 7 deletions.
diff --git a/python/lsst/fgcmcal/fgcmOutputProducts.py b/python/lsst/fgcmcal/fgcmOutputProducts.py
@@ -175,6 +175,8 @@ class FgcmOutputProductsConfig(pipeBase.PipelineTaskConfig,
         doc="Final fit cycle from FGCM fit",
         dtype=int,
         default=None,
+        deprecated=("This config is no longer used, and will be removed after v25. "
+                    "Please set config.connections.cycleNumber directly instead."),
     )
     physicalFilterMap = pexConfig.DictField(
         doc="Mapping from 'physicalFilter' to band.",
@@ -281,12 +283,6 @@ def setDefaults(self):
         self.photoCal.match.sourceSelection.flags.bad = ['flag_badStar']
         self.photoCal.match.sourceSelection.doUnresolved = False
 
-    def validate(self):
-        super().validate()
-
-        # Force the connections to conform with cycleNumber
-        self.connections.cycleNumber = str(self.cycleNumber)
-
 
 class FgcmOutputProductsTask(pipeBase.PipelineTask):
     """

diff --git a/tests/config/fgcmOutputProductsHsc.py b/tests/config/fgcmOutputProductsHsc.py
@@ -4,7 +4,7 @@
 import os.path
 
 
-config.cycleNumber = 2
+config.connections.cycleNumber = 2
 
 config.doReferenceCalibration = True