DM-38398: Fix crashes exposed by rc2_subset. #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurenam
approved these changes
Mar 22, 2023
| @@ -166,7 +166,7 @@ def setDefaults(self): | |||
| source_selector = self.sourceSelector["science"] | |||
| source_selector.setDefaults() | |||
|
|
|||
| source_selector.doFlags = True | |||
| source_selector.doFlags = False | |||
There was a problem hiding this comment.
Did you really mean to turn off (even the default science selector) flag filtering by default?
There was a problem hiding this comment.
Yes, this is intentional. When running from the isolated stars the flags have already all been applied in the original isolated star association task, except for the local background flag. What I have now may be redundant I realize, but it does work.
| @@ -388,8 +388,11 @@ def _make_all_star_obs_from_isolated_stars( | |||
| self.config.apertureOuterInstFluxField + "Err", | |||
| ] | |||
|
|
|||
| local_background_flag_name = None | |||
There was a problem hiding this comment.
I'm not seeing why this initialization is necessary (as the other use below is also behind a if self.config.doSubtractLocalBackground: clause)...
laurenam
reviewed
Mar 22, 2023
| ) | ||
| loop_bands = self.config.requiredBands | ||
| else: | ||
| loop_bands = np.unique(sources['band']) |
There was a problem hiding this comment.
Double vs. single quotes again.
erykoff
force-pushed
the
tickets/DM-38398
branch
from
fff9ce0
to
8053578
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a flag loading issue, and an index error that can come with very thin data like rc2_subset when all of the observations of a given star are flagged as bad due to having no flux after correcting for the local background.