DM-40322: Implement new connections hook for refcat lookups. #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erykoff
requested changes
Aug 8, 2023
| @@ -135,6 +135,9 @@ def __init__(self, *, config=None): | |||
| if not config.fgcmOutputProducts.doZeropointOutput: | |||
| self.prerequisiteInputs.remove("fgcmZeropoints") | |||
|
|
|||
| def getSpatialBoundsConnections(self): | |||
| return ("isolated_star_cats", "visit_summaries") | |||
|
|
|||
There was a problem hiding this comment.
There's no isolated_star_cats in the tract version.
There was a problem hiding this comment.
👍, the other also needs to be renamed to visitSummary.
| @@ -149,6 +149,9 @@ def __init__(self, *, config=None): | |||
| if not config.doReferenceMatches: | |||
| self.outputs.remove("fgcmReferenceStars") | |||
|
|
|||
| def getSpatialBoundsConnections(self): | |||
| return ("visit_summaries",) | |||
There was a problem hiding this comment.
I think this should be visitSummary?
This is part of a new, slightly-better fix for DM-40243.
TallJimbo
force-pushed
the
tickets/DM-40322
branch
from
402a410
to
ab2a956
Compare
erykoff
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of a new, slightly-better fix for DM-40243.