Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-43033: Minor updates and bug fixes for ComCamSim run. #118

Merged
merged 3 commits into from
Mar 6, 2024
Merged

DM-43033: Minor updates and bug fixes for ComCamSim run. #118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a7a376a
Add additional check for no good stars in a tract.
erykoff Mar 1, 2024
95fbc5f
Fix units when loading a healpix region.
erykoff Mar 1, 2024
c8f2297
Add configuration to reserve/skip a fraction of reference stars.
erykoff Mar 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions python/lsst/fgcmcal/fgcmBuildFromIsolatedStars.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -481,6 +481,10 @@ def _make_all_star_obs_from_isolated_stars(
# above the limit.
(good_stars,) = (n_req.max(axis=0) >= self.config.minPerBand).nonzero()

if len(good_stars) == 0:
self.log.info("No good stars found in tract %d", tract)
continue

# With the following matching:
# sources[good_sources][b] <-> stars[good_stars[a]]
obj_index = sources["obj_index"][good_sources]
Expand Down
6 changes: 6 additions & 0 deletions python/lsst/fgcmcal/fgcmFitCycle.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,6 +381,12 @@ class FgcmFitCycleConfig(pipeBase.PipelineTaskConfig,
dtype=bool,
default=True,
)
refStarMaxFracUse = pexConfig.Field(
doc=("Maximum fraction of reference stars to use in the fit. Remainder will "
"be used only for validation."),
dtype=float,
default=0.5,
)
useExposureReferenceOffset = pexConfig.Field(
doc=("Use per-exposure (visit) offsets between calibrated stars and reference stars "
"for final zeropoints? This may help uniformity for disjoint surveys."),
Expand Down
2 changes: 1 addition & 1 deletion python/lsst/fgcmcal/fgcmLoadReferenceCatalog.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ def getFgcmReferenceStarsHealpix(self, nside, pixel, filterList, nest=False):

# Determine the size of the sky circle to load
lon, lat = hpg.pixel_to_angle(nside, pixel, nest=nest, degrees=False)
center = lsst.geom.SpherePoint(lon * lsst.geom.degrees, lat * lsst.geom.radians)
center = lsst.geom.SpherePoint(lon * lsst.geom.radians, lat * lsst.geom.radians)

theta_phi = hpg.boundaries(nside, pixel, step=1, nest=nest, lonlat=False)

Expand Down
1 change: 1 addition & 0 deletions python/lsst/fgcmcal/utilities.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,7 @@ def makeConfigDict(config, log, camera, maxIter,
'refStarSnMin': config.refStarSnMin,
'refStarOutlierNSig': config.refStarOutlierNSig,
'applyRefStarColorCuts': config.applyRefStarColorCuts,
'refStarMaxFracUse': config.refStarMaxFracUse,
'useExposureReferenceOffset': config.useExposureReferenceOffset,
'illegalValue': FGCM_ILLEGAL_VALUE, # internally used by fgcm.
'starColorCuts': starColorCutList,
Expand Down