DM-16127: Move fgcmcal from lsst-dm to lsst #2
Conversation
|
Another thing: you need to add |
|
A useful addition to the cookbook would be a comment on roughly how long each step will take to complete on lsst-dev. |
|
Timing information has now been added to the cookbook. |
There was a problem hiding this comment.
You need license info in your python files. Unless you're going with a different license, which is certainly possible, this is the LSST boilerplate: https://developer.lsst.io/stack/license-and-copyright.html?highlight=license#python-preamble
Question about convergence criteria: you say "15 for testing, 50+ for a full run": is there a better way to understand whether one has chosen an appropriate number of steps? Can you improve the step size or convergence criteria in the code to make that unnecessary?
README.md
Outdated
|
|
||
| This is LSST stack code to interface with the FGCM package. See | ||
| http://adsabs.harvard.edu/abs/2018AJ....155...41B for the paper describing the | ||
| method, and https://github.com/erykoff/fgcm for a Python implementation that is | ||
| method, and https://github.com/erykoff/fgcm (as forked in | ||
| https://github.com/lsst/fgcm ) for the Python implementation that is |
There was a problem hiding this comment.
Is it worth mentioning here that the lsst fork follows the lsst-dev branch instead of master?
bin.src/fgcmFitCycle.py
Outdated
| @@ -1,5 +1,8 @@ | |||
| #!/usr/bin/env python | |||
| # See COPYRIGHT file at the top of the source tree. | |||
| import matplotlib | |||
| matplotlib.use("Agg") # noqa | |||
There was a problem hiding this comment.
These can be marked #noqa E402 to make it more explicit.
|
Since one of the goals here was to give As you push to this branch, I'll sync that branch up when you tell me it's appropriate. |
r-owen
force-pushed
the
tickets/DM-16127
branch
5 times, most recently
from
46c0798
to
d68ff46
Compare
|
Question from Eli on the detailed review that @TallJimbo or @r-owen might know the answer to: parejkoj#1 (comment) |
Add fgcm, testdata_joincal to required and optional packages; Add setup.cfg for flake8 settings and exclusions; Move matplotlib backend setting; Update installation instructions; Use LoadIndexedReferenceObjectsTask.makeMinimalSchema to make reference catalog schema; Add approximate timing information to cookbook; Update copyright and licenses; Rename variables as needed (e.g. mag -> instMag); Remove unused code; Streamline methods; expand documentation; add missing docstrings; add references to tickets for future updates; Use cameraGain from butler; add .travis.yml; add module docstrings; Better handle on-disk angle units; Update README.
erykoff
force-pushed
the
tickets/DM-16127
branch
from
f43193c
to
25cfb16
Compare
No description provided.