Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-21814: Add tracking of calib_psfCandidate flags. #21

Merged
merged 2 commits into from Nov 4, 2019

Conversation

erykoff
Copy link
Contributor

@erykoff erykoff commented Oct 30, 2019

Now fgcm will aggregate the stars that have the calib_psfCandidate flag and
count the number of times this is set (as well as the total number of
observations). The output is in the final output refcat with the
band_nPsfCandidate field.

Now fgcm will aggregate the stars that have the calib_psfCandidate flag and
count the number of times this is set (as well as the total number of
observations).  The output is in the final output refcat with the
band_nPsfCandidate field.
Copy link
Member

@TallJimbo TallJimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I think this is the first time I've looked at anything in fgcmcal, so I've got no context, but all of the changes individually look totally reasonable.

Also use the old psf candidate name for tests because the test data was
processed with a much older stack.
@erykoff erykoff merged commit ea722c6 into master Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants