DM-20163: Use PixelAreaBoundedField in fgcmcal calibration outputs #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmeyers314
approved these changes
Jan 9, 2020
python/lsst/fgcmcal/utilities.py
Outdated
| def makeZptSchema(chebyshevSize): | ||
| def computeReferencePixelScale(camera): | ||
| """ | ||
| Compute the average pixel scale in the camera |
There was a problem hiding this comment.
Might just say median instead of average.
| @@ -105,7 +105,7 @@ def test_fgcmcalTasks(self): | |||
| nGoodZp = 26 | |||
| nOkZp = 26 | |||
| nBadZp = 1206 | |||
| nStdStars = 390 | |||
| nStdStars = 389 | |||
There was a problem hiding this comment.
It's not clear to me why these magic numbers are changing. Maybe insert a note in the commit message where they changed?
erykoff
force-pushed
the
tickets/DM-20163
branch
from
2eaf80f
to
9c4feac
Compare
…ration. With new ProductBoundedField and PixelAreaBoundedField in afw we can properly decompose the photometric calibration into the constituent parts. The jacobian computations are done using camera geometry because of performance issues (this is much, much faster), and tests show that this is more reliable, and consistent at the 1 mmag level with the predictions from the SkyWcs. Because of the changes in the way the photometric calibration is computed (wcs jacobian + illumination correction + gray), the test values have changed slightly and the number of "good" stars in the calibration changed. Finally, additional configuration parameters for automatically selecting per-cycle photometric cuts were added.
erykoff
force-pushed
the
tickets/DM-20163
branch
from
8d57eb9
to
f5d8d20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use new features of afw, including
PixelAreaBoundedFieldandProductBoundedFieldto decompose photometric calibration into wcs jacobian component, star-flat (illumination correction) component, and gray component.