DM-16700: Update for latest version of fgcm, including log PWV and filter offsets. #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sr525
reviewed
Dec 19, 2018
| doc='Global offset for retrieved log(pwv)') | ||
| parSchema.addField('parRetrievedLnPwvNightlyOffset', type='ArrayD', | ||
| doc='Nightly offset for retrieved log(pwv)', | ||
| size=pars['PARRETRIEVEDLNPWVNIGHTLYOFFSET'].size) |
There was a problem hiding this comment.
I'd prefer if ln and log were used consistently (i.e. the same in the doc and the field name) but that might just be personal preference.
Add support for latest fgcm, including fitting in ln(PWV) space, quadratic temporal variation of ln(PWV), offsets between cross-calibrated filters (e.g., HSC r/r2 and i/i2), and estimation of the systematic error floor in the calibration. Another fit cycle was added to the tests, as this excercises key bits of the code where fit parameters are re-ingested. Schema doc strings are updated to use "ln" instead of "log" for consistency.
erykoff
force-pushed
the
tickets/DM-16700
branch
from
c067ffa
to
897cb34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for latest fgcm, including fitting in ln(PWV) space, quadratic
temporal variation of ln(PWV), offsets between cross-calibrated filters (e.g.,
HSC r/r2 and i/i2), and estimation of the systematic error floor in the
calibration. Another fit cycle was added to the tests, as this excercises
key bits of the code where fit parameters are re-ingested.