DM-26085: Fix fgcmcal zeropoint offset due to background offset. #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurenam
reviewed
Aug 12, 2020
The local background subtraction code has been refactored to move the computations into the fgcm code. This allows fgcm to compute background offset statistics and account for any net offsets in the zeropoints. The chromatic correction code has been updated to report the average chromatic correction per ccd. This yields better repeatability when the full pipeline does not include chromatic terms (as is the case currently). Additional tests have been added to check for remaining net offsets and ensure they are small (<2 mmag).
erykoff
force-pushed
the
tickets/DM-26085
branch
from
6fcc6a4
to
be4178d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The local background subtraction code has been refactored to move the
computations into the fgcm code. This allows fgcm to compute background offset
statistics and account for any net offsets in the zeropoints. The chromatic
correction code has been updated to report the average chromatic correction per
ccd. This yields better repeatability when the full pipeline does not include
chromatic terms (as is the case currently). Additional tests have been added
to check for remaining net offsets and ensure they are small (<2 mmag).