DM-28088: Replace uses of filter with physicalFilter as appropriate. #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erykoff
force-pushed
the
tickets/DM-28088
branch
from
c67d0a2
to
6cd1f88
Compare
erykoff
force-pushed
the
tickets/DM-28088
branch
from
6cd1f88
to
d74f671
Compare
parejkoj
reviewed
Feb 3, 2021
There was a problem hiding this comment.
Overall, this looks like a useful cleanup (besides being necessary for removing afw Filter).
My biggest concern is with the new stdPhysicalFilterMap: I think it should just map x->x unless something different is specified. Is there a reason one has to have a duplicated map like that (and in multiple configs, too!)?
erykoff
force-pushed
the
tickets/DM-28088
branch
from
d74f671
to
e32d575
Compare
parejkoj
reviewed
Feb 4, 2021
erykoff
force-pushed
the
tickets/DM-28088
branch
from
e32d575
to
6c0cde7
Compare
erykoff
force-pushed
the
tickets/DM-28088
branch
from
d08f4e3
to
1875237
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.