DM-29017: Update to new detector id-indexed visitSummary catalog. #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parejkoj
approved these changes
Mar 3, 2021
| @@ -95,7 +95,9 @@ class FgcmBuildStarsTableConnections(pipeBase.PipelineTaskConnections, | |||
| ) | |||
|
|
|||
| visitSummary = connectionTypes.Input( | |||
| doc="Per-visit summary statistics table", | |||
| doc=("Per-visit consolidated exposure metadata. These catalogs use " | |||
| "detector id for the id and are sorted for fast lookups of a " | |||
There was a problem hiding this comment.
Because this is Input, I would phrase it as "...and must be sorted for fast ...", since that's a requirement on the files, not something this package guarantees.
erykoff
force-pushed
the
tickets/DM-29017
branch
from
c698a31
to
ca225b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.