DM-28597: Fix colorterm/photoCal filterLabel confusion #55
Conversation
| @@ -745,7 +747,7 @@ def generateTractOutputProducts(self, dataRefDict, tract, | |||
|
|
|||
| return retStruct | |||
|
|
|||
| def _computeReferenceOffsets(self, stdCat, bands): | |||
| def _computeReferenceOffsets(self, stdCat, lutCat, physicalFilterMap, bands): | |||
| """ | |||
| Compute offsets relative to a reference catalog. | |||
There was a problem hiding this comment.
When we chatted, you mentioned that this was mostly used for testing. Should that be made clear in the docs? Because I worry that the implementation may now break if someone tries to use it on data that has multiple physical filters mapping to the same band.
| # Find a physical filter associated from the band by doing | ||
| # a reverse lookup on the physicalFilterMap dict | ||
| physicalFilterMapIndex = physicalFilterMapBands.index(band) | ||
| physicalFilter = physicalFilterMapFilters[physicalFilterMapIndex] |
There was a problem hiding this comment.
It probably doesn't matter for the tests this is used in, but I suspect this will not give the results we want for e.g. HSC data that has both HSC-I and HSC-I2, because those are both band="i".
There was a problem hiding this comment.
The way the lookup works is that we go from band to a physical filter and then to the standard filter. In the case that we have both HSC-I and HSC-I2, these two physical filters will be mapped to the same standard filter (the default is HSC-I2). This is enforced in the fgcm code that that you can't have a band mapped to more than one standard filter. Therefore, we get i to HSC-I to HSC-I2 or i to HSC-I2 to HSC-I2 but no matter the lookup path you end up with the same standard filter, and the one that was specified should be used (and thus get the correct color terms). I'll add more comments in the code.
erykoff
force-pushed
the
tickets/DM-28597
branch
from
b3160fa
to
dd165f0
Compare
parejkoj
force-pushed
the
tickets/DM-28597
branch
from
dd165f0
to
74c8f17
Compare
No description provided.