DM-21215: Add FocalPlaneProjector for fgcm camera rotations. #75
Conversation
|
|
||
| wcsDict = {} | ||
|
|
||
| for i, detector in enumerate(self.camera): |
There was a problem hiding this comment.
Looks like this could just be for detector in self.camera
| delta_ra_cent, delta_dec_cent, delta_ra, delta_dec for | ||
| each detector id. | ||
| """ | ||
| if not np.isfinite(orientation): |
There was a problem hiding this comment.
Are you intentionally using nan or inf as a sentinel for something? Should this raise an Error instead perhaps? Maybe this behavior just needs some documentation.
There was a problem hiding this comment.
Some early engineering HSC data that we have tested on in the past has nans here ... but the current test data doesn't. So I'll add a warning (but not raise) if it encounters this.
|
|
||
| Returns | ||
| ------- | ||
| projectionMapping : `np.darray` |
| # Put the reference boresight at the equator to avoid cos(dec) problems. | ||
| self.boresight = geom.SpherePoint(180.0*geom.degrees, 0.0*geom.degrees) | ||
| self.flipX = False | ||
| self.defaultOrientation = int(defaultOrientation) |
There was a problem hiding this comment.
Do you want to deal with -90 = 270 here or elsewhere?
There was a problem hiding this comment.
Good question. I'll look and see where the best place to wrap would be.
| Parameters | ||
| ---------- | ||
| orientation : `int` | ||
| Camera orientation in degrees. Integerized for better caching. |
There was a problem hiding this comment.
Can orientation be defined? Is this the angle between camera +y and North, for instance?
There was a problem hiding this comment.
erykoff
force-pushed
the
tickets/DM-21215
branch
from
89f0b1a
to
44b57b1
Compare
erykoff
force-pushed
the
tickets/DM-21215
branch
from
44b57b1
to
a14d8ba
Compare
No description provided.