Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-16701: Add sub-ccd spatially variable gray terms to fgcmcal #8

Merged
merged 1 commit into from Jan 24, 2019
Merged

DM-16701: Add sub-ccd spatially variable gray terms to fgcmcal #8

merged 1 commit into from Jan 24, 2019

Conversation

erykoff
Copy link
Contributor

@erykoff erykoff commented Jan 17, 2019

No description provided.

taranu
taranu reviewed Jan 24, 2019
View reviewed changes
Copy link

@taranu taranu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look fine to me. The behavior of the output*BeforeFinalCycle fields doesn't seem entirely intuitive based on the name/description of the field but looks sensible otherwise, so a minor edit of the docs should suffice.

cookbook/README.md Outdated Show resolved Hide resolved
python/lsst/fgcmcal/fgcmFitCycle.py Show resolved Hide resolved
python/lsst/fgcmcal/fgcmFitCycle.py Show resolved Hide resolved
tests/test_chebyshev.py Outdated Show resolved Hide resolved
tests/test_chebyshev.py Show resolved Hide resolved
tests/test_chebyshev.py Outdated Show resolved Hide resolved
tests/test_chebyshev.py Outdated Show resolved Hide resolved
@erykoff
Add option to compute ccd gray corrections at the sub-ccd scale.
82fb475 
This update works with the updated fgcm v1.9.9.1 which adds the ability to
compute ccd gray corrections with chebyshev polynomials, which are then
combined with the super star-flat parametrization.  A small half-pixel shift in
the chebyshev implementation in the stack and fgcm was found and tests were
added to check that everything works the same now.  The trigger of the final
fit cycle has been updated to simply setting "isFinalCycle=True", and this
functionality was added to the tests.  The hsc tests were updated to use the
new sub-ccd gray correction and comparison values were updated accordingly
(changes at the <0.1 mmag level).
@erykoff erykoff merged commit abd0d4b into master Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taranu taranu taranu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@erykoff @taranu