DM-36944: Update lookup table comparison values after changing to float64. #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The values are now computed in fgcm using float64 internally, which removes some floating-point rounding errors. The new values are "more correct" and also consistent across scipy versions.
kherner
approved these changes
Nov 9, 2022
| I0STD = [0.08294534, 0.07877351, 0.06464688] | ||
| I10STD = [-0.000091981, -0.00061516, -0.00063434] | ||
| I0RECON = [0.07322632, 0.0689530429, 0.05600673] | ||
| I10RECON = [-5.89806616479, -7.01786443508, 3.62738180611] |
There was a problem hiding this comment.
I do see that the I10RECON numbers are slightly different from what was there before; I don't know enough to say which values are right.
There was a problem hiding this comment.
These are computed by explicitly doing the simpson integration with all float64 inputs, and I'm assuming that is "more correct". Also, they're now consistent across scipy versions of the simpson integration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The values are now computed in fgcm using float64 internally, which removes some floating-point rounding errors. The new values are "more correct" and also consistent across scipy versions.