Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-39700: Remove std::unary_function #12

Merged
merged 2 commits into from Jun 20, 2023
Merged

DM-39700: Remove std::unary_function #12

merged 2 commits into from Jun 20, 2023

Conversation

mwittgen
Copy link

No description provided.

erykoff
erykoff approved these changes Jun 20, 2023
View reviewed changes
Copy link

@erykoff erykoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sure this is fine, and this is way outside my c++ knowledge ... but for result_type to mean anything does SinFunction need to subclass std::function or something?

@mwittgen
Copy link
Author

I'm sure this is fine, and this is way outside my c++ knowledge ... but for result_type to mean anything does SinFunction need to subclass std::function or something?

std::*_function would store a template parameter in result_type. SinFunction does not inherit from the function class template anymore. One could change result_type to double, but this solution is fine.

@mwittgen mwittgen merged commit c329cc8 into lsst-dev Jun 20, 2023
@mwittgen mwittgen deleted the tickets/DM-39700 branch June 20, 2023 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erykoff erykoff erykoff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@mwittgen @erykoff