DM-40652: Make SVD calculation optional #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me! Just some minor optional comments. |
arunkannawadi
approved these changes
Dec 7, 2023
| @@ -1240,75 +1240,77 @@ double CoordAlign::fitOnce(bool reportToCerr, bool inPlace) { | |||
| // SVD, which is what we want anyway to find the non-pos-def values | |||
|
|
|||
| if (choleskyFails) { | |||
| cerr << "Caught exception during Cholesky" << endl; | |||
There was a problem hiding this comment.
Is dropping this line intentional?
There was a problem hiding this comment.
Yeah, because you just get the same message again in the std::runtime_error(), so this std::cerr message isn't necessary.
src/subs/WCSFitRoutine.cpp
Outdated
| @@ -507,6 +507,21 @@ void WCSFit::fit(double maxError, int minFitExposures, double reserveFraction, i | |||
| } | |||
| if (verbose >= 0) std::cerr << "# Clipped " << nclip << " matches " << std::endl; | |||
|
|
|||
| auto badExposures = findUnderpopulatedExposures<Astro>(minFitExposures, matches, exposures, | |||
| extensions, mapCollection); | |||
There was a problem hiding this comment.
The second line isn't indented correctly.
cmsaunders
force-pushed
the
tickets/DM-40652
branch
from
3526d98
to
8963d62
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.