DM-42536: Change std::set to std::vector to ensure repeatability #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmsaunders
force-pushed
the
tickets/DM-42536
branch
from
aed61d7
to
bf75cd7
Compare
erykoff
approved these changes
Jan 19, 2024
include/WcsSubs.h
Outdated
| @@ -20,7 +20,7 @@ typedef Astro::ColorExtension ColorExtension; | |||
| // Function that will using starting WCS to fit all of the defaulted | |||
| // maps used by the selected extensions. Then will put the | |||
| // initialized parameters back into the PMC and clear the defaulted flag. | |||
| void fitDefaulted(astrometry::PixelMapCollection &pmc, set<Extension *> useThese, | |||
| void fitDefaulted(astrometry::PixelMapCollection &pmc, vector<Extension *> useThese, | |||
There was a problem hiding this comment.
I don't think it matters, but should the variable be renamed here to match the .cpp?
There was a problem hiding this comment.
Yeah, I think that's a good idea.
cmsaunders
force-pushed
the
tickets/DM-42536
branch
from
bf75cd7
to
cdac21c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.