Add test for NaN when comparing angles

Otherwise Angle(NaN) was comparing favorably with any non-NaN angle.
lsst · Oct 3, 2018 · ce41766 · ce41766
1 parent 017a494
commit ce41766
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/python/lsst/geom/testUtils.py b/python/lsst/geom/testUtils.py
@@ -68,6 +68,10 @@ def assertAnglesAlmostEqual(testCase, ang0, ang1, maxDiff=0.001*arcseconds,
     AssertionError
         Raised if the difference is greater than ``maxDiff``
     """
+    if math.isnan(ang0.asRadians()):
+        testCase.fail("ang0 is NaN")
+    if math.isnan(ang1.asRadians()):
+        testCase.fail("ang1 is NaN")
     measDiff = ang1 - ang0
     if ignoreWrap:
         measDiff = measDiff.wrapCtr()

diff --git a/tests/test_testUtils.py b/tests/test_testUtils.py
@@ -97,6 +97,12 @@ def testAssertAnglesAlmostEqual(self):
                     maxDiff=0.009999*lsst.geom.arcseconds,
                 )
 
+        # Compare with NaN
+        ang0 = float("NaN")*lsst.geom.degrees
+        ang1 = 1.*lsst.geom.degrees
+        with self.assertRaises(AssertionError):
+            self.assertAnglesAlmostEqual(ang0, ang1)
+
     def testAssertBoxesAlmostEqual(self):
         """Test assertBoxesAlmostEqual"""
         for min0 in ((0, 0), (-1000.5, 5000.1)):