DM-38457: Add an __iter__ to Point and Extent #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default implementation for __iter__ is to use __getitem__ repeatedly until IndexError is raissed. This is incredibly expensive on macOS with Apple silicon and is unnecessary because Point and Extent have a predefined number of elements. This change uses the .dimensions property to limit the iterator.
TallJimbo
approved these changes
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default implementation for iter is to use getitem repeatedly until IndexError is raissed. This is incredibly expensive on macOS with Apple silicon and is unnecessary because Point and Extent have a predefined number of elements. This change uses the .dimensions property to limit the iterator.