U/pgee/dm 980b #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please enter the commit message for your changes. Lines starting
pgee2000
force-pushed
the
u/pgee/DM-980b
branch
from
459943f
to
c0b62a6
Compare
|
|
||
| /** | ||
| * @brief Intermediate base class for algorithms that compute a centroid. | ||
| */ | ||
| class DipoleCentroidAlgorithm : public meas::algorithms::Algorithm { | ||
| class DipoleCentroidAlgorithm : public lsst::meas::base::SimpleAlgorithm { |
There was a problem hiding this comment.
Why is the whole namespace used here when it is not elsewhere in this file?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.