DM-15635: Approximate filter throughput for DcrCoadds #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrawls
reviewed
Oct 20, 2018
python/lsst/ip/diffim/dcrModel.py
Outdated
| @@ -549,23 +552,37 @@ def applyDcr(maskedImage, dcr, warpCtrl, bbox=None, useInverse=False): | |||
| Shifts the entire image if None (Default). | |||
| useInverse : `bool`, optional | |||
| Use the reverse of ``dcr`` for the shift. Default: False | |||
| useMidpoint : `bool`, optional | |||
| Use the midpoint of each subfilter to calculate DCR. Default: True | |||
There was a problem hiding this comment.
Can you clarify in the doctoring what the behavior is if this is False? I think it uses the start and endpoint of each filter instead, but saying that here would be helpful.
There was a problem hiding this comment.
I'm going to actually rename useMidpoint to splitSubfilters, with a default of False. That will make the documentation more clear.
python/lsst/ip/diffim/dcrModel.py
Outdated
| @@ -578,14 +595,17 @@ def calculateDcr(visitInfo, wcs, filterInfo, dcrNumSubfilters): | |||
| The filter definition, set in the current instruments' obs package. | |||
| dcrNumSubfilters : `int` | |||
| Number of sub-filters used to model chromatic effects within a band. | |||
| useMidpoint : `bool`, optional | |||
| Use the midpoint of each subfilter to calculate DCR. Default: True | |||
There was a problem hiding this comment.
Again, please briefly say what happens if useMidpoint is set to False.
isullivan
force-pushed
the
tickets/DM-15635
branch
from
1d25ca5
to
ab6a5d8
Compare
isullivan
force-pushed
the
tickets/DM-15635
branch
from
ab6a5d8
to
b61b41e
Compare
mrawls
approved these changes
Oct 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.