Tickets/DM-16864: New frequency regularization using relative model #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isullivan
force-pushed
the
tickets/DM-16864
branch
from
bfb8133
to
b019423
Compare
isullivan
force-pushed
the
tickets/DM-16864
branch
from
b019423
to
ee64c72
Compare
kgabor
approved these changes
Jan 31, 2019
isullivan
force-pushed
the
tickets/DM-16864
branch
from
8d1d0bd
to
e1d653a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This significantly changes the form of frequency regularization when building a DcrModel. Before, frequency regularization was performed on each pixel mostly independently, which permitted some chromatic artifacts in the wings of detected sources. This new regularization scheme instead calculates a smoothly-varying "rubber sheet" for each subfilter, and restricts the new subfilter image to be the product of that deformation and an average reference image.