DM-18565: Shrink the bbox before constructing a DCR-matched template. #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isullivan
force-pushed
the
tickets/DM-18565
branch
from
32df093
to
34ddf2c
Compare
isullivan
force-pushed
the
tickets/DM-18565
branch
from
34ddf2c
to
9218b85
Compare
The DCR model creates artifacts over a few pixels at the edges of each patch. Patches have sufficient overlap to negate this, but when the `coaddPatch` is added to the `coaddExposure` the entire patch out to the outer bounding box is inserted, over-writing any data already there. This means that the last patch added will include artifacts at the edge. One possible fix is to shrink the outer bounding boxes by a few pixels, so that the edge of the overlap region is cut. This prevents the later patches from overwriting good pixels in the boundary region with data contaminated by artifacts.
isullivan
force-pushed
the
tickets/DM-18565
branch
from
9218b85
to
8b5099e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DCR model creates artifacts over a few pixels at the edges of each patch. Patches have sufficient overlap to negate this, but when the
coaddPatchis added to thecoaddExposurethe entire patch out to the outer bounding box is inserted, over-writing any data already there. This means that the last patch added will include artifacts at the edge. One possible fix is to shrink the outer bounding boxes by a few pixels, so that the edge of the overlap region is cut. This prevents the later patches from overwriting good pixels in the boundary region with data contaminated by artifacts.