U/yusra/dm 3515 #13
Merged
U/yusra/dm 3515 #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @register("ip_diffim_ClassificationDipole") | ||
| class ClassificationDipolePlugin(SingleFramePlugin): | ||
| """ | ||
| A binary measure of the whether a diasource is a dipole. |
There was a problem hiding this comment.
Maybe better: "A plugin to classify whether a diaSource is a dipole."
There was a problem hiding this comment.
This was just copied pasted. I will update.
DipoleMeasurement exists to run a method to
classify dipoles after run(). This classification conforms
to our current measurent framework as a plugin here.
- Change field names in schema to:
"ip_diffim_ClassificationDipole_value"
"ip_diffim_ClassificationDipole_flag"
(modeled after ClassificationExtendedness)
- Make no changes to algorithm that sets _value
Because the classification method was moved to a plugin, the special run() method which runs classification as an afterburner is no longer necessary. DipoleMeasurementTask is now just a SingleFrameMeasurementTask with a default configuration enabling the diffim-specific plugins.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.