Tickets/dm 11991 -- Fix relative calibration between images for ZOGY algorithm #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parejkoj
approved these changes
Dec 20, 2019
There was a problem hiding this comment.
The code changes look ok. However, please ensure the PR title matches the standard:
https://developer.lsst.io/work/flow.html#make-a-pull-request
|
Also, your note in the PR description says "scaleByCalibration is set to True by default", but looking at the code, it defaults to False. |
wmwv
force-pushed
the
tickets/DM-11991
branch
from
244451d
to
06b2878
Compare
🤦♂ |
kgabor
approved these changes
Dec 27, 2019
…eFluxScaling.
If scaleByCalibration is True, but the calibraiton is not available for both images
then revert to the defined {template,science}FluxScaling values.
wmwv
force-pushed
the
tickets/DM-11991
branch
from
daf2630
to
2bc5861
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets the ZOGY Fn, Fr normalizations based on the photometric calibration of each image with new
scaleByCalibrationoption inZogyTaskconfig. Option is set toTrueby default.