DM-21237: Add bbox check before constructing dcrModel. #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The coadd patch contains a large buffer of pixels on all sides, and the dcrModel requires that a small number of those get clipped to prevent artifacts at patch boundaries. This adds a check before trying to build the dcrModel to skip a patch if there will not be enough pixels remaining to build a model. In that case, the patch should be skipped in any case, since any valid data would be contained in neighboring patches anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The coadd patch contains a large buffer of pixels on all sides, and the dcrModel requires that a small number of those get clipped to prevent artifacts at patch boundaries. This adds a check before trying to build the dcrModel to skip a patch if there will not be enough pixels remaining to build a model. In that case, the patch should be skipped in any case, since any valid data would be contained in neighboring patches anyway.