one pixel shift #147
Closed
one pixel shift #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The center of the padded PSF from _padPsfToSize is moved to the center-right.
|
Thank you for this, @shuliu2017! I'm closing this PR so that we can handle it on #148. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When padding a PSF with (odd, odd) dimension to (even, even) dimension, the center of the PSF should be placed to the center-right of the array. Otherwise the peak value could be shifted to the end of the array after applying np.fft.fftshift(e.g. Correct padding: [0,0,1,2,3,2,1,0] -> [3,2,1,0,0,0,1,2], Incorrect padding: [0,1,2,3,2,1,0,0] - > [2,1,0,0, 0,1,2,3]). This corresponds to a one pixel offset since the np.fft.fft assume the first component of the array as the origin.