Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-23426: Use PipelineTask test framework for MetricTask #151

Merged
merged 1 commit into from
Apr 2, 2020
Merged

DM-23426: Use PipelineTask test framework for MetricTask #151

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 8 additions & 0 deletions tests/test_metrics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@

from lsst.afw.table import SourceCatalog
import lsst.utils.tests
import lsst.pipe.base.testUtils
from lsst.verify import Name
from lsst.verify.gen2tasks.testUtils import MetricTaskTestCase
from lsst.verify.tasks import MetricComputationError
Expand All @@ -50,6 +51,7 @@ def makeTask(cls):
def testValid(self):
catalog = _makeDummyCatalog(3)
result = self.task.run(catalog)
lsst.pipe.base.testUtils.assertValidOutput(self.task, result)
meas = result.measurement

self.assertEqual(meas.metric_name, Name(metric="ip_diffim.numSciSources"))
Expand All @@ -58,13 +60,15 @@ def testValid(self):
def testEmptyCatalog(self):
catalog = _makeDummyCatalog(0)
result = self.task.run(catalog)
lsst.pipe.base.testUtils.assertValidOutput(self.task, result)
meas = result.measurement

self.assertEqual(meas.metric_name, Name(metric="ip_diffim.numSciSources"))
self.assertEqual(meas.quantity, 0 * u.count)

def testMissingData(self):
result = self.task.run(None)
lsst.pipe.base.testUtils.assertValidOutput(self.task, result)
meas = result.measurement
self.assertIsNone(meas)

Expand All @@ -79,6 +83,7 @@ def testValid(self):
sciCatalog = _makeDummyCatalog(5)
diaCatalog = _makeDummyCatalog(3)
result = self.task.run(sciCatalog, diaCatalog)
lsst.pipe.base.testUtils.assertValidOutput(self.task, result)
meas = result.measurement

self.assertEqual(meas.metric_name, Name(metric="ip_diffim.fracDiaSourcesToSciSources"))
Expand All @@ -88,6 +93,7 @@ def testEmptyDiaCatalog(self):
sciCatalog = _makeDummyCatalog(5)
diaCatalog = _makeDummyCatalog(0)
result = self.task.run(sciCatalog, diaCatalog)
lsst.pipe.base.testUtils.assertValidOutput(self.task, result)
meas = result.measurement

self.assertEqual(meas.metric_name, Name(metric="ip_diffim.fracDiaSourcesToSciSources"))
Expand All @@ -107,11 +113,13 @@ def testEmptyCatalogs(self):

def testMissingData(self):
result = self.task.run(None, None)
lsst.pipe.base.testUtils.assertValidOutput(self.task, result)
meas = result.measurement
self.assertIsNone(meas)

def testSemiMissingData(self):
result = self.task.run(sciSources=_makeDummyCatalog(3), diaSources=None)
lsst.pipe.base.testUtils.assertValidOutput(self.task, result)
meas = result.measurement
self.assertIsNone(meas)

Expand Down