DM-22952: Gen 3 version of DCR image differencing #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgabor
reviewed
Apr 22, 2020
python/lsst/ip/diffim/dcrModel.py
Outdated
| mask = None | ||
| variance = None | ||
| photoCalib = None | ||
| modelImages = [[] for _s in range(len(availableCoaddRefs))] |
There was a problem hiding this comment.
There should be exactly one image per subfilter in a stored model shouldn't be ? I'd recommend to initialize modelImages with a list of None-s as they are simply replaced later. What about [None, ] * len(availableCoaddRefs) ?
isullivan
force-pushed
the
tickets/DM-22952
branch
3 times, most recently
from
1b5139e
to
376ed22
Compare
isullivan
force-pushed
the
tickets/DM-22952
branch
from
376ed22
to
7d4fe2d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.