DM-25115 Implement zogy subtraction with non-spatial PSF #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isullivan
approved these changes
Jun 18, 2020
There was a problem hiding this comment.
Because there were so many changes, I reviewed this as if it was brand-new code.
Most of my comments are relatively minor, or are requests for more clarification. My main remaining confusion is about the name "score" that occurs throughout. I thought this was a typo for "Scorr", but it shows up in so many places it seems intentional. Please add an explanation about what is being "scored" and what that means in the docstrings of the methods where it shows up.
isullivan
approved these changes
Jun 18, 2020
* Add image calibration and preparation steps. * Separate full and sub exposure preparation for future grid processing. * Add zogy difference image calculation. * Add making an exposure of the difference image array. * Task entry point is now run(). * Unit test: DFT normalization convention, sourceless and with source fake images. * Minor fix in uni test image generation regarding PSF centroid pixel. * Add variance plane and S score image calculation. * Add avoid division by zero handling when both psf are zero. * Update docstrings. * Use numpy random number generator framework in fake image generation. * Add ImagePsfMatchTask wrapper around new zogy implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.