DM-26182 Fix zogy score image invalid value warning #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isullivan
approved these changes
Aug 20, 2020
python/lsst/ip/diffim/zogy.py
Outdated
| flt = np.logical_or(flt, self.fftVarPl2.filtInf) | ||
| flt = np.logical_or(flt, self.fftVarPl1.filtNaN) | ||
| flt = np.logical_or(flt, self.fftVarPl2.filtNaN) | ||
| tiny = np.finfo(varPlaneS.dtype).tiny * 100 |
There was a problem hiding this comment.
Why did this change from tiny*10 to tiny*100?
Also, move this line two lines down below the comment that explains it's purpose.
There was a problem hiding this comment.
In calculateFourierDiffim, I use tiny*100, changed for consistency.
* Avoid comparison of non-finite floats with thresholds. * Replace score with zero and score variance with one at these pixels irrespectively of mask values.
kgabor
force-pushed
the
tickets/DM-26182
branch
from
996bac3
to
fa67b7f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.