Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-27170: Deprecate and phase out afw::image::Filter #170

Merged
merged 1 commit into from Jan 29, 2021
Merged

DM-27170: Deprecate and phase out afw::image::Filter #170

merged 1 commit into from Jan 29, 2021

Conversation

parejkoj
Copy link
Contributor

@parejkoj parejkoj commented Jan 2, 2021

No description provided.

kfindeisen
kfindeisen approved these changes Jan 5, 2021
View reviewed changes
Copy link
Member

@kfindeisen kfindeisen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I understand the point of renaming all the variables, but otherwise looks good.

@parejkoj
Replace deprecated Filter interface with FilterLabel
c87a66f 
FilterInfo was now just used for the labels, so is now just a label.
@parejkoj parejkoj merged commit f422365 into master Jan 29, 2021
@parejkoj parejkoj deleted the tickets/DM-27170 branch January 29, 2021 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kfindeisen kfindeisen kfindeisen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@parejkoj @kfindeisen