Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-28442 Fix variance plane calculation scaling in non-normalized matching kernel case #174

Merged
merged 1 commit into from Feb 11, 2021
Merged

DM-28442 Fix variance plane calculation scaling in non-normalized matching kernel case #174

merged 1 commit into from Feb 11, 2021

Conversation

kgabor
Copy link
Member

@kgabor kgabor commented Feb 9, 2021

  • Add templateMatched to ImageDecorrelation and add variance scaling in science convolution mode.
  • Add the new option to pass on in the DecorrelateALSpatialTask mapper layer.

morriscb
morriscb approved these changes Feb 9, 2021
View reviewed changes
Copy link
Contributor

@morriscb morriscb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Needs some clean up of the comments around where I noted as it doesn't read very clearly.

python/lsst/ip/diffim/imagePsfMatch.py Show resolved Hide resolved
python/lsst/ip/diffim/imageDecorrelation.py Outdated Show resolved Hide resolved
Fix missed variance scaling in variance plane calculation.
571b46e 
 * Add templateMatched to ImageDecorrelation and add variance scaling in science convolution mode.
 * Add the new option to pass on in the DecorrelateALSpatialTask mapper layer.
 * Comments and docstrings update.
@kgabor kgabor merged commit 9eb8d17 into master Feb 11, 2021
@kgabor kgabor deleted the tickets/DM-28442 branch February 11, 2021 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morriscb morriscb morriscb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kgabor @morriscb