fixes enabling DipoleFitTask in imageDifference command-line task #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonKrughoff
commented
May 16, 2016
SimonKrughoff
commented
- add dipoleFitTask.py to exports
- fix error/warning reporting
- add DipoleFitTaskConfig
1. add dipoleFitTask.py to exports 2. fix error/warning reporting 3. add DipoleFitTaskConfig
| ] | ||
|
|
||
| self.slots.calibFlux = None | ||
| self.slots.modelFlux = None |
There was a problem hiding this comment.
Couldn't we make the modelFlux slot the ip_diffim_PsfDipoleFlux?
There was a problem hiding this comment.
That is not the current behavior. PsfDipoleFlux does not set an overall flux (just separate fluxes for pos. and neg. lobes). I would set it to the flux from ip_diffim_DipoleFit, but I am not sure how to, since that task is not formally "registered" as a plugin (this will be fixed in a future ticket after the sfm overhaul).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.