DM-6056: replace CONST_PTR and PTR macros by std::shared #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwittgen
force-pushed
the
tickets/DM-6056
branch
from
e13d341
to
9f97638
Compare
mwittgen
force-pushed
the
tickets/DM-6056
branch
from
9f97638
to
283ec3d
Compare
mwittgen
changed the title
kfindeisen
approved these changes
Aug 30, 2021
src/DipoleAlgorithms.cc
Outdated
| @@ -358,14 +358,14 @@ std::pair<double,int> PsfDipoleFlux::chi2( | |||
| geom::Point2D negCenter(negCenterX, negCenterY); | |||
| geom::Point2D posCenter(posCenterX, posCenterY); | |||
|
|
|||
| CONST_PTR(afw::detection::Footprint) footprint = source.getFootprint(); | |||
| std::shared_ptr<afw::detection::Footprint const > footprint = source.getFootprint(); | |||
There was a problem hiding this comment.
Suggested change
| std::shared_ptr<afw::detection::Footprint const > footprint = source.getFootprint(); | |
| std::shared_ptr<afw::detection::Footprint const> footprint = source.getFootprint(); |
mwittgen
force-pushed
the
tickets/DM-6056
branch
from
283ec3d
to
970987a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.