DM-30927: Set calexp WCS to None for failed astrometric fit #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurenam
force-pushed
the
tickets/DM-30927
branch
from
8181501
to
a2ce461
Compare
laurenam
force-pushed
the
tickets/DM-30927
branch
from
a2ce461
to
7131fa9
Compare
laurenam
force-pushed
the
tickets/DM-30927
branch
from
7131fa9
to
c67ad0f
Compare
laurenam
force-pushed
the
tickets/DM-30927
branch
from
c67ad0f
to
dee2158
Compare
erykoff
approved these changes
Sep 14, 2022
timj
reviewed
Sep 14, 2022
python/lsst/ip/diffim/getTemplate.py
Outdated
| `lsst.daf.butler.DeferredDatasetHandle` of | ||
| `lsst.afw.image.Exposure` | ||
| Dict of the patches containing valid data for each tract. | ||
| coaddRefs : `list` |
There was a problem hiding this comment.
Have you run package-docs build on this branch? This multi-line listing of types makes sphinx very upset. I think you need to instead do something like
"""
coaddRefs : `list` [`lsst.daf.butler.DeferredDatasetHandle`]
Data references to `~lsst.afw.Image.Exposure` representing DcrModels
that overlap the detector.
"""There was a problem hiding this comment.
So, no, I had not...but I have now. I admit to knowing nothing about sphinx, so am happy to go with your suggestion. For the record, I ran package-docs build on the branch as is and copied the doc folder to my local machine and looked at it via opening doc/_build/html/index.html and here's what it looks like:
and with your edit:
Either works for me!
🤷 |
Specifically, if the exposure under consideration has its WCS set to None, do not attempt to retrieve the difference imaging template.
laurenam
force-pushed
the
tickets/DM-30927
branch
from
dee2158
to
86c72ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.