Add early error message if using calexp as template and no id supplied #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -168,6 +168,8 @@ def run(self, exposure, sensorRef, templateIdList): | |||
| if len(templateIdList) > 1: | |||
| self.log.warn("Multiple template visits supplied. Getting template from first visit: %s" % | |||
| (templateIdList[0]['visit'])) | |||
| if len(templateIdList) == 0: | |||
| raise RuntimeError("No template supplied! Please supply a template visit id.") | |||
There was a problem hiding this comment.
I suggest you swap the two tests, to fail early.
Also, please improve the documentation for the templateIdList argument: indicate that the list should contain a single item, and if it contains more then only the first is used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.