DM-31777: Build CoaddPsf of CoaddPsfs in tract WCS #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TallJimbo
approved these changes
Nov 10, 2021
There was a problem hiding this comment.
Looks like there are a few more lines you can remove now, because warped doesn't survive outside that for loop:
652: xyTransform = afwGeom.makeWcsPairTransform(coaddPatch.getWcs(), finalWcs)
653: psfWarped = WarpedPsf(coaddPatch.getPsf(), xyTransform)
661: warped.setPsf(psfWarped)
You may not need to import WarpedPsf after that, either.
yalsayyad
force-pushed
the
tickets/DM-31777
branch
from
5a34fd0
to
a85a5a9
Compare
Previously it was loading the PSFs pre-warped to the detector WCS. CoaddPsf warps when evaluating anyway so pre-warping is overkill and harder to debug.
yalsayyad
force-pushed
the
tickets/DM-31777
branch
from
a85a5a9
to
b8be260
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it was loading the PSFs pre-warped to the detector WCS.
CoaddPsf warps when evaluating anyway so pre-warping is overkill
and harder to debug.