DM-35674: Remove Gen2 code #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only worked for Gen2
This task seems to be deprecated but it still referenced from pipe_tasks.
isullivan
approved these changes
Aug 2, 2022
There was a problem hiding this comment.
These changes all look good. There are a few more places in the run method of GetCoaddAsTemplateTask where comments about Gen2-only behavior could be removed, but since that class will be removed entirely in the (near) future I don't think it's essential to remove them now (e.g. lines 199 and 288).
|
I fixed line 199. I wasn't really sure what line 288 was saying to me. Did it mean that those few lines should be deleted because gen3 will never have a problem, or should the comment itself be removed. Since the class is going away I left it in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.