DM-34628: Variance underestimated in patch overlaps in templates #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yalsayyad
force-pushed
the
tickets/DM-34628
branch
from
1ff5a43
to
e864f6f
Compare
yalsayyad
changed the title
isullivan
commented
Nov 4, 2022
python/lsst/ip/diffim/getTemplate.py
Outdated
| @@ -571,7 +571,7 @@ def run(self, coaddExposures, bbox, wcs, dataIds, **kwargs): | |||
| statsCtrl = afwMath.StatisticsControl() | |||
| statsCtrl.setNanSafe(True) | |||
| statsCtrl.setWeighted(True) | |||
| statsCtrl.setCalcErrorFromInputVariance(True) | |||
| statsCtrl.setCalcErrorMosiacMode(True) | |||
There was a problem hiding this comment.
Suggested change
| statsCtrl.setCalcErrorMosiacMode(True) | |
| statsCtrl.setCalcErrorMosaicMode(True) |
yalsayyad
force-pushed
the
tickets/DM-34628
branch
2 times, most recently
from
b92460f
to
bb6e703
Compare
While mosaicking coadds to make templates, use the mean variances of neighboring coadds to construct the template variance plane in the patch overlap region. The coadds have had identical visits contributing to them and are approximately 100% correlated. While they may not be exactly 100% correlated (they've had different backgrounds applied) they are much much closer to 100% correlated than 0% like calcErrorFromInputVariance assumes.
yalsayyad
force-pushed
the
tickets/DM-34628
branch
from
bb6e703
to
3198c2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.