DM-36717: Diffim bug fixes #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
isullivan
commented
Oct 26, 2022
isullivan
commented
- Uses a more accurate PSF FWHM for constructing the kernel basis list
- Applies the template PhotoCalib before constructing the PSF matching kernel
- Rejects flagged sources and sky sources from source list before selecting kernel candidates.
isullivan
force-pushed
the
tickets/DM-36717
branch
2 times, most recently
from
fa455de
to
03a7a11
Compare
kherner
approved these changes
Nov 3, 2022
python/lsst/ip/diffim/utils.py
Outdated
|
|
||
| Parameters | ||
| ---------- | ||
| psf : `lsst.afw.detection.Psf` | ||
| Point spread function (PSF) to evaluate. | ||
| average : `bool`, optional | ||
| Set to return the average width. | ||
|
|
||
| Returns | ||
| ------- | ||
| psfSize : `float` |
There was a problem hiding this comment.
Does the returns description need to be changed since you could also be returning what appears to be a tuple when average = False?
| # put the template on the same photometric scale as the science image | ||
| photoCalib = template.getPhotoCalib() | ||
| self.log.info("Applying photometric calibration to template: %f", photoCalib.getCalibrationMean()) | ||
| template.maskedImage = photoCalib.calibrateImage(template.maskedImage) |
There was a problem hiding this comment.
Where is the science image involved here?
There was a problem hiding this comment.
It's not, the template is read in with units of counts, so this applies the template's calibration to put it in nJy. That should make it comparable to the science image, which should make work slightly easier for calculating the matching kernel.
| candidateList=sources, | ||
| preconvolved=False) | ||
| selectSources = self._sourceSelector(sources) | ||
| self.log.info("%i sources used out of %i from the input catalog", len(selectSources), len(sources)) |
There was a problem hiding this comment.
Would it make sense to do some alerting/error raising if zero sources are selected? Might save time later...
isullivan
force-pushed
the
tickets/DM-36717
branch
from
03a7a11
to
82e78da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.