Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-37283: Remove compatibility mode from subtractImages #239

Merged
merged 1 commit into from Dec 14, 2022
Merged

DM-37283: Remove compatibility mode from subtractImages #239

merged 1 commit into from Dec 14, 2022

Conversation

isullivan
Copy link
Contributor

This option was scheduled to be removed after release 25, which will be based on weekly 48.

@bsmartradio bsmartradio self-requested a review December 8, 2022 21:25
bsmartradio
bsmartradio approved these changes Dec 13, 2022
View reviewed changes
Copy link
Contributor

@bsmartradio bsmartradio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good. I checked that there wasn't any missed pieces of code, and tried sconsing it. There were no complaints, and all the warnings of forcedCompatibility were removed.

@isullivan isullivan merged commit 520cfd9 into main Dec 14, 2022
@isullivan isullivan deleted the tickets/DM-37283 branch December 14, 2022 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsmartradio bsmartradio bsmartradio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@isullivan @bsmartradio