DM-35962: Remove examples/ from all packages #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isullivan
approved these changes
Jan 4, 2023
There was a problem hiding this comment.
I am concerned that we appear to be losing a useful example with the removal of maskedKernel.cc. The removed notes from KernelSolution.cc suggest that this is for getting the indexing right, and since this code has not changed in a long time I suspect it is still relevant. That code would be more useful if it could be translated into a unit test, though. Could you file a ticket to create a replacement unit test?
|
Created DM-37514 to make a unittest out of the removed file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.