DM-37770: use pybind wrappers, merge into one pybind shared lib #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwittgen
force-pushed
the
tickets/DM-37770
branch
from
9dc8a60
to
088aa7a
Compare
TallJimbo
approved these changes
Feb 6, 2023
| @@ -19,4 +19,4 @@ | |||
| # the GNU General Public License along with this program. If not, | |||
| # see <https://www.lsstcorp.org/LegalNotices/>. | |||
| # | |||
| from .diffimDetailLib import * | |||
| from .._ipdiffimLib import * | |||
There was a problem hiding this comment.
I hate the fact that we're exposing things in the detail namespace to Python at all, but it's preexisting (and probably so tests could be written in Python), so I suppose this isn't the right ticket to do anything about that.
mwittgen
force-pushed
the
tickets/DM-37770
branch
from
088aa7a
to
59b00ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.