DM-37884: Include all evaluateMeanPsfFwhm in try/except blocks #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arunkannawadi
commented
Feb 7, 2023
python/lsst/ip/diffim/makeKernel.py
Outdated
| except InvalidParameterError: | ||
| self.log.info("Unable to evaluate PSF at the average position. " | ||
| "Evaluting PSF on a grid of points." | ||
| ) |
There was a problem hiding this comment.
I don't know if logging this information in many places is helpful. For a given template with a CoaddPsf error, this line might end up appearing several times.
There was a problem hiding this comment.
I think you're right. This message would appear once already from subtractImages.py, so I would suggest downgrading the log messages here (and below) to debug
arunkannawadi
force-pushed
the
tickets/DM-37884
branch
from
fb935de
to
603d04d
Compare
isullivan
approved these changes
Feb 7, 2023
python/lsst/ip/diffim/makeKernel.py
Outdated
| except InvalidParameterError: | ||
| self.log.info("Unable to evaluate PSF at the average position. " | ||
| "Evaluting PSF on a grid of points." | ||
| ) |
There was a problem hiding this comment.
I think you're right. This message would appear once already from subtractImages.py, so I would suggest downgrading the log messages here (and below) to debug
python/lsst/ip/diffim/makeKernel.py
Outdated
| templateFwhmPix = getPsfFwhm(template.psf) | ||
| scienceFwhmPix = getPsfFwhm(science.psf) | ||
| except InvalidParameterError: | ||
| self.log.info("Unable to evaluate PSF at the average position. " |
There was a problem hiding this comment.
As above, downgrade to debug
|
Thanks for the comment, Ian. I downgraded the logging level for these to be |
arunkannawadi
force-pushed
the
tickets/DM-37884
branch
from
f9a22ad
to
7f3cbdd
Compare
arunkannawadi
force-pushed
the
tickets/DM-37884
branch
from
7f3cbdd
to
091ee38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the fix that should have been in place in #246 . All evaluateMeanPsfFwhm calls must be within an
exceptblock and should be called only aftergetPsfFwhmhas been tried first.