Add DecorrelateALKernelTask #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "computeClippedImageStats") | ||
|
|
||
|
|
||
| def computeClippedImageStats(im): | ||
| def computeClippedImageStats(im, numSigmaClip=3., numIter=3): |
There was a problem hiding this comment.
I suggest removing this function entirely. You only call it in two places in this file, and those two places can use the same statsControl object, so it's very few extra lines of code. Furthermore, in this file you ignore two out of the three statistics that you compute (you apparently only use the variance). I don't feel this is a good function to make public, either.
There was a problem hiding this comment.
It is also used by the unit test, which is why I made it public -- but I understand your point. I will do what you suggested, and reimplement it in the unit test.
|
Please be sure to squash the new commits before merging. |
move utility functions into task Updates from code review Remove scipy convolution option fix unit test and docstrings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
move utility functions into task