DM-32406: Fix lmfit>1.0.2 failures and cleanup dipole code #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsmartradio
approved these changes
Feb 17, 2023
Comment on lines
760
to
759
| psf=self.diffim.getPsf(), # hereon: kwargs that get passed to genDipoleModel() | ||
| psf=self.diffim.getPsf(), # hereon: kwargs that get passed to makeModel() |
There was a problem hiding this comment.
Did you mean to duplicate this line? It looks like psf=self.diffim.getPsf(), wouldn't change between these two lines.
There was a problem hiding this comment.
Thanks: it got fixed on the next commit, but I've cleaned up those two.
There was a squashed `maxfev`-related warning; only the kwarg warnings should be squashed here.
maxfev/maxiter both result in a warning and are ignored by lmfit.
This is a "single instance per test" helper class; name it after the class itself for clarity.
While trying to use this, I discovered that verbose/debug are only used in one test, so there's nothing to be gained except confusion by having them in the helper class.
This is where we would substitute a different fitter (e.g. minpack `least_squares`), which might be worth testing.
lmfit>1.0.2 coerces the data and independent variables to float64, but our internal model images are float32, so the default step sizes are too small and the fits fail. Changing our model images to double would be slower and take up more memory; epsfcn>1e-13 seems to be enough to get good fits: step length is proportional to sqrt(epsfcn). If we switch to least_squares, we would instead set `diff_step` here.
parejkoj
force-pushed
the
tickets/DM-32406
branch
from
1a0c687
to
181e71c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.