Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-38901: Clear the template mask plane in image differencing #257

Merged
merged 3 commits into from
May 6, 2023
Merged

DM-38901: Clear the template mask plane in image differencing #257

merged 3 commits into from
May 6, 2023

Commits on May 6, 2023

  1. Clear the mask plane of the template after initial calculations.

    @isullivan
    isullivan committed May 6, 2023
    Configuration menu
    Copy the full SHA
    401fef4 View commit details
    Browse the repository at this point in the history

  2. Fix existing unit tests after clearing the template mask. 

    The modifications in `test_order_equal_images` are needed because there is no border padding of the template.
The changes in `test_symmetry` are needed to make the images actually symmetric. This should have been the case before, but after clearing the EDGE flag the `template_better.difference` image was entirely NANs due to the statistics calculation in decorrelation still needing a mask plane. This was fixed by copying the difference mask plane to the template before decorrelation.
    @isullivan
    isullivan committed May 6, 2023
    Configuration menu
    Copy the full SHA
    353979b View commit details
    Browse the repository at this point in the history

  3. Add unit test for diffim mask plane behavior.

    @isullivan
    isullivan committed May 6, 2023
    Configuration menu
    Copy the full SHA
    ff935c2 View commit details
    Browse the repository at this point in the history