DM-38246: SourceDetectionTask will not detect on pixels flagged as NO_DATA or EDGE #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TallJimbo
approved these changes
May 15, 2023
tests/test_detectAndMeasure.py
Outdated
| "xSize": xSize, "ySize": ySize} | ||
| dipoleFlag = "ip_diffim_DipoleFit_flag_classification" | ||
| # kwargs = {"seed": staticSeed, "psfSize": 2.4, "fluxLevel": fluxLevel, "fluxRange": fluxRange, | ||
| # "nSrc": nSources} |
There was a problem hiding this comment.
Commented lines here look like relics.
| else: | ||
| self.assertEqual(np.sum(~goodSrcFlags), 0) | ||
| for diaSource, goodSrcFlag in zip(output.diaSources, goodSrcFlags): | ||
| if ~goodSrcFlag: |
There was a problem hiding this comment.
What type is goodSrcFlag here, and why ~ instead of not? I'm used to seeing that elementwise inversion of numpy arrays, but you also can't test for the truthiness of an entire array like this, so I wonder if you really mean if not goodSrcFlag.any() here.
There was a problem hiding this comment.
This test is a little simpler than that: it's iterating through all of the sources, so goodSrcFlag is a single boolean. I could certainly change that to not goodSrcFalg for readability.
| else: | ||
| self.assertEqual(np.sum(~goodSrcFlags), 0) | ||
| for diaSource, goodSrcFlag in zip(output.diaSources, goodSrcFlags): | ||
| if ~goodSrcFlag: |
There was a problem hiding this comment.
Same comment as in the other test method.
isullivan
force-pushed
the
tickets/DM-38246
branch
2 times, most recently
from
382ad3a
to
35e975a
Compare
isullivan
force-pushed
the
tickets/DM-38246
branch
from
35e975a
to
bfdd4cc
Compare
isullivan
force-pushed
the
tickets/DM-38246
branch
from
bfdd4cc
to
530f9ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.